Skip to content

Error occurs if ConnectionFactoryOptions.PROTOCOL option is an empty string #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nakamura-to opened this issue Jan 8, 2023 · 1 comment · Fixed by #112
Closed

Error occurs if ConnectionFactoryOptions.PROTOCOL option is an empty string #111

nakamura-to opened this issue Jan 8, 2023 · 1 comment · Fixed by #112

Comments

@nakamura-to
Copy link

Hi. The error occurs in v1.1.0 but not in v1.0.0.

I guess we need to check if the protocol is empty here.
https://github.com/oracle/oracle-r2dbc/blob/1.1.0/src/main/java/oracle/r2dbc/impl/OracleReactiveJdbcAdapter.java#L407

In some cases,　r2dbc-pool sets an empty string to the ConnectionFactoryOptions.PROTOCOL option.
https://github.com/r2dbc/r2dbc-pool/blob/v1.0.0.RELEASE/src/main/java/io/r2dbc/pool/PoolingConnectionFactoryProvider.java#L180
@nakamura-to nakamura-to mentioned this issue Jan 8, 2023
Closed
1 task
@Michael-A-McMahon
Copy link
Member

Thanks for finding this. The driver should be treating an empty string as if the protocol was not set.
I'll have a fix for this soon.

@Michael-A-McMahon Michael-A-McMahon mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle empty protocol option oracle/oracle-r2dbc
2 participants
@nakamura-to @Michael-A-McMahon