Handle empty protocol option #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
jeandelavarene
approved these changes
Jan 16, 2023
|
Hi, is it possible to have a new versión with this fix? |
|
I think we are overdue for one. This fix seems critical as I would consider r2dbc-pool to be the defacto solution for pooling R2DBC connections. I'll see if I can get the process started on this. Probably a patch release numbered as 1.1.1 would be appropriate, as no major features have been added since 1.1.0 back in November 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111
If the protocol option is set to an empty string, then it is treated the same as if no value had been set. This is done for compatibility with the R2DBC Pool project.