Repairing javadocs #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch repairs the JavaDoc of Oracle R2DBC in preparation for the 1.0.0 release.
The pom.xml updates jar artifacts to have the 1.0.0 version number. It also specifies a sourcepath attribute for generating the JavaDoc jar. Maven's JavaDoc plugin won't generate javadocs for package private classes without the sourcepath attribute. I could not find any documentation which explains why.
All JavaDoc errors are now fixed; Things like missing param and return tags, or invalid HTML.
A package-info.java file is added for the oracle.r2dbc package. The package info documents the package as intended for consumption by external code.