Skip to content

misc: fix grammar and spelling #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jbampton
Copy link

@jbampton jbampton commented Apr 4, 2025

Thanks for contributing!

Before submitting PRs for python-oracledb you must have your signed Oracle
Contributor Agreement
accepted. See https://oca.opensource.oracle.com

If the problem solved is small, you may find it easier to open an Issue
describing the problem and its cause so we can create the fix.

The bottom of your commit message must have the following line using your name
and e-mail address as it appears in the OCA Signatories list.

Signed-off-by: Your Name <[email protected]>

This can be automatically added to pull requests by committing with:

git commit --signoff

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 4, 2025
@cjbj
Copy link
Member

cjbj commented Apr 4, 2025

Excellent - thanks for the contribution. I'll merge it to our internal repo, and then @anthony-tuininga will push back here to GitHub when he does his next round of updates.

@cjbj
Copy link
Member

cjbj commented Apr 4, 2025

I've created our internal PR and it will wend its way back to GitHub in the near future. The attention to detail is appreciated.

  • I left nanoarrow.c since we take that from upstream.
  • There was one small grammar fix of "a universal2" to "an universal2" that I didn't agree with and didn't make.

@cjbj cjbj closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants