Add subject to OciImageManifest #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
requested review from
thomastaylor312,
bacongobbler and
flavio
as code owners
|
Out of curiosity, where did you find the NOT_FOUND error code? I cannot find it listed under https://github.com/opencontainers/distribution-spec/blob/main/spec.md#error-codes There is a mention of legacy docker support error codes which states "these error codes are OPTIONAL and clients SHOULD NOT depend on them". I did notice both |
|
I was seeing a serde json deserialization error saying "not found" was an unexpected error code variant when querying for a manifest that didn't exist. Adding this variant fixed it and allowed me to check the code to determine existence of an artifact. |
Signed-off-by: Brian H <[email protected]>
fibonacci1729
force-pushed
the
subject
branch
from
395a6df to
3a7131d
Compare
|
@thomastaylor312 I think this is ready for review when you get a chance |
|
@fibonacci1729 just for reference this was with Harbor, correct? |
|
That's correct! |
bacongobbler
approved these changes
Nov 7, 2024
flavio
added a commit
to flavio/rust-oci-client
that referenced
this pull request
Apr 16, 2025
== What's Changed * Add artifactType to OciImageIndex by @rylev in oras-project#182 * chore(deps): Bump actions/checkout from 4.2.1 to 4.2.2 by @dependabot in oras-project#183 * Add subject to OciImageManifest by @fibonacci1729 in oras-project#181 * chore: Updates thiserror and fixes cargo deny by @thomastaylor312 in oras-project#185 * chore(deps): Update itertools requirement from 0.13.0 to 0.14.0 by @dependabot in oras-project#188 * chore(deps): Update rstest requirement from 0.23.0 to 0.24.0 by @dependabot in oras-project#186 * chore(deps): Update axum requirement from 0.7 to 0.8 by @dependabot in oras-project#187 * feat: Direct Bearer Token Authentication by @prabhpreet in oras-project#191 * chore(deps): Update rstest requirement from 0.24.0 to 0.25.0 by @dependabot in oras-project#193 * feat: add HTTP proxy for client by @Xynnn007 in oras-project#194 * Improve error message by @aochagavia in oras-project#196 == New Contributors * @fibonacci1729 made their first contribution in oras-project#181 * @prabhpreet made their first contribution in oras-project#191 **Full Changelog**: oras-project/rust-oci-client@v0.14.0...v0.15.0 Signed-off-by: Flavio Castelli <[email protected]>
flavio
added a commit
to flavio/rust-oci-client
that referenced
this pull request
May 15, 2025
== What's Changed * Add artifactType to OciImageIndex by @rylev in oras-project#182 * chore(deps): Bump actions/checkout from 4.2.1 to 4.2.2 by @dependabot in oras-project#183 * Add subject to OciImageManifest by @fibonacci1729 in oras-project#181 * chore: Updates thiserror and fixes cargo deny by @thomastaylor312 in oras-project#185 * chore(deps): Update itertools requirement from 0.13.0 to 0.14.0 by @dependabot in oras-project#188 * chore(deps): Update rstest requirement from 0.23.0 to 0.24.0 by @dependabot in oras-project#186 * chore(deps): Update axum requirement from 0.7 to 0.8 by @dependabot in oras-project#187 * feat: Direct Bearer Token Authentication by @prabhpreet in oras-project#191 * chore(deps): Update rstest requirement from 0.24.0 to 0.25.0 by @dependabot in oras-project#193 * feat: add HTTP proxy for client by @Xynnn007 in oras-project#194 * Improve error message by @aochagavia in oras-project#196 * Print username in get-manifest command by @stepancheg in oras-project#200 * chore(deps): Update oci-spec requirement from 0.7.0 to 0.8.1 by @dependabot in oras-project#201 * chore(deps): Update testcontainers requirement from 0.23 to 0.24 by @dependabot in oras-project#202 == New Contributors * @fibonacci1729 made their first contribution in oras-project#181 * @prabhpreet made their first contribution in oras-project#191 * @stepancheg made their first contribution in oras-project#200 **Full Changelog**: oras-project/rust-oci-client@v0.14.0...v0.15.0 Signed-off-by: Flavio Castelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows creating accessory artifacts that can be associated with artifacts in a repository. Additionally added a missing error code.