chore(internal): require explicit overrides

pyproject.toml

@@ -102,6 +102,9 @@ exclude = [
     ".venv",
     ".nox",
 ]
+
+reportImplicitOverride = true
+
 reportImportCycles = false
 reportPrivateUsage = false
 

src/orb/_base_client.py

@@ -29,7 +29,7 @@
     overload,
 )
 from functools import lru_cache
-from typing_extensions import Literal, get_args, get_origin
+from typing_extensions import Literal, get_args, override, get_origin
 
 import anyio
 import httpx
@@ -1588,6 +1588,7 @@ class OtherPlatform:
     def __init__(self, name: str) -> None:
         self.name = name
 
+    @override
     def __str__(self) -> str:
         return f"Other:{self.name}"
 
@@ -1649,6 +1650,7 @@ class OtherArch:
     def __init__(self, name: str) -> None:
         self.name = name
 
+    @override
     def __str__(self) -> str:
         return f"other:{self.name}"
 

src/orb/_client.py

@@ -5,6 +5,7 @@
 import os
 import asyncio
 from typing import Union, Mapping
+from typing_extensions import override
 
 import httpx
 
@@ -118,10 +119,12 @@ def __init__(
         self.subscriptions = resources.Subscriptions(self)
 
     @property
+    @override
     def qs(self) -> Querystring:
         return Querystring(array_format="comma")
 
     @property
+    @override
     def auth_headers(self) -> dict[str, str]:
         api_key = self.api_key
         return {"Authorization": f"Bearer {api_key}"}
@@ -188,6 +191,7 @@ def __del__(self) -> None:
 
         self.close()
 
+    @override
     def _make_status_error(
         self,
         err_msg: str,
@@ -346,10 +350,12 @@ def __init__(
         self.subscriptions = resources.AsyncSubscriptions(self)
 
     @property
+    @override
     def qs(self) -> Querystring:
         return Querystring(array_format="comma")
 
     @property
+    @override
     def auth_headers(self) -> dict[str, str]:
         api_key = self.api_key
         return {"Authorization": f"Bearer {api_key}"}
@@ -419,6 +425,7 @@ def __del__(self) -> None:
         except Exception:
             pass
 
+    @override
     def _make_status_error(
         self,
         err_msg: str,

src/orb/_models.py

@@ -11,6 +11,7 @@
     Required,
     TypedDict,
     final,
+    override,
     runtime_checkable,
 )
 
@@ -59,20 +60,23 @@ class BaseModel(pydantic.BaseModel):
     else:
 
         @property
+        @override
         def model_fields_set(self) -> set[str]:
             # a forwards-compat shim for pydantic v2
             return self.__fields_set__  # type: ignore
 
         class Config(pydantic.BaseConfig):  # pyright: ignore[reportDeprecated]
             extra: Any = pydantic.Extra.allow  # type: ignore
 
+    @override
     def __str__(self) -> str:
         # mypy complains about an invalid self arg
         return f'{self.__repr_name__()}({self.__repr_str__(", ")})'  # type: ignore[misc]
 
     # Override the 'construct' method in a way that supports recursive parsing without validation.
     # Based on https://github.com/samuelcolvin/pydantic/issues/1168#issuecomment-817742836.
     @classmethod
+    @override
     def construct(
         cls: Type[ModelT],
         _fields_set: set[str] | None = None,
@@ -139,6 +143,7 @@ def construct(
         # a specifc pydantic version as some users may not know which
         # pydantic version they are currently using
 
+        @override
         def model_dump(
             self,
             *,
@@ -187,6 +192,7 @@ def model_dump(
                 exclude_none=exclude_none,
             )
 
+        @override
         def model_dump_json(
             self,
             *,

src/orb/_streaming.py

@@ -3,6 +3,7 @@
 
 import json
 from typing import TYPE_CHECKING, Any, Generic, Iterator, AsyncIterator
+from typing_extensions import override
 
 import httpx
 
@@ -123,6 +124,7 @@ def data(self) -> str:
     def json(self) -> Any:
         return json.loads(self.data)
 
+    @override
     def __repr__(self) -> str:
         return f"ServerSentEvent(event={self.event}, data={self.data}, id={self.id}, retry={self.retry})"
 

src/orb/_types.py

@@ -15,7 +15,14 @@
     Optional,
     Sequence,
 )
-from typing_extensions import Literal, Protocol, TypeAlias, TypedDict, runtime_checkable
+from typing_extensions import (
+    Literal,
+    Protocol,
+    TypeAlias,
+    TypedDict,
+    override,
+    runtime_checkable,
+)
 
 import httpx
 import pydantic
@@ -119,6 +126,7 @@ def get(timeout: Union[int, NotGiven, None] = NotGiven()) -> Response: ...
     def __bool__(self) -> Literal[False]:
         return False
 
+    @override
     def __repr__(self) -> str:
         return "NOT_GIVEN"
 

src/orb/_utils/_proxy.py

@@ -2,7 +2,7 @@
 
 from abc import ABC, abstractmethod
 from typing import Generic, TypeVar, Iterable, cast
-from typing_extensions import ClassVar
+from typing_extensions import ClassVar, override
 
 T = TypeVar("T")
 
@@ -21,16 +21,20 @@ def __init__(self) -> None:
     def __getattr__(self, attr: str) -> object:
         return getattr(self.__get_proxied__(), attr)
 
+    @override
     def __repr__(self) -> str:
         return repr(self.__get_proxied__())
 
+    @override
     def __str__(self) -> str:
         return str(self.__get_proxied__())
 
+    @override
     def __dir__(self) -> Iterable[str]:
         return self.__get_proxied__().__dir__()
 
     @property  # type: ignore
+    @override
     def __class__(self) -> type:
         return self.__get_proxied__().__class__
 

src/orb/_utils/_transform.py

@@ -2,7 +2,7 @@
 
 from typing import Any, List, Mapping, TypeVar, cast
 from datetime import date, datetime
-from typing_extensions import Literal, get_args, get_type_hints
+from typing_extensions import Literal, get_args, override, get_type_hints
 
 from ._utils import (
     is_list,
@@ -52,6 +52,7 @@ def __init__(
         self.format = format
         self.format_template = format_template
 
+    @override
     def __repr__(self) -> str:
         return f"{self.__class__.__name__}(alias='{self.alias}', format={self.format}, format_template='{self.format_template}')"
 

src/orb/pagination.py

@@ -1,6 +1,7 @@
 # File generated from our OpenAPI spec by Stainless.
 
 from typing import List, Generic, TypeVar, Optional
+from typing_extensions import override
 
 from ._types import ModelT
 from ._models import BaseModel
@@ -21,9 +22,11 @@ class SyncPage(BaseSyncPage[ModelT], BasePage[ModelT], Generic[ModelT]):
     data: List[ModelT]
     pagination_metadata: PagePaginationMetadata
 
+    @override
     def _get_page_items(self) -> List[ModelT]:
         return self.data
 
+    @override
     def next_page_info(self) -> Optional[PageInfo]:
         cursor = self.pagination_metadata.next_cursor
         if not cursor:
@@ -36,9 +39,11 @@ class AsyncPage(BaseAsyncPage[ModelT], BasePage[ModelT], Generic[ModelT]):
     data: List[ModelT]
     pagination_metadata: PagePaginationMetadata
 
+    @override
     def _get_page_items(self) -> List[ModelT]:
         return self.data
 
+    @override
     def next_page_info(self) -> Optional[PageInfo]:
         cursor = self.pagination_metadata.next_cursor
         if not cursor: