Skip to content

feat(api): remove accidental null #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/orb/resources/customers/costs.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ def list(
self,
customer_id: Optional[str],
*,
timeframe_end: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_end: Union[str, datetime] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime] | NotGiven = NOT_GIVEN,
view_mode: Optional[Literal["periodic", "cumulative"]] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand Down Expand Up @@ -232,8 +232,8 @@ def list_by_external_id(
self,
external_customer_id: Optional[str],
*,
timeframe_end: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_end: Union[str, datetime] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime] | NotGiven = NOT_GIVEN,
view_mode: Optional[Literal["periodic", "cumulative"]] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand Down Expand Up @@ -433,8 +433,8 @@ async def list(
self,
customer_id: Optional[str],
*,
timeframe_end: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_end: Union[str, datetime] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime] | NotGiven = NOT_GIVEN,
view_mode: Optional[Literal["periodic", "cumulative"]] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand Down Expand Up @@ -622,8 +622,8 @@ async def list_by_external_id(
self,
external_customer_id: Optional[str],
*,
timeframe_end: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_end: Union[str, datetime] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime] | NotGiven = NOT_GIVEN,
view_mode: Optional[Literal["periodic", "cumulative"]] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand Down
8 changes: 4 additions & 4 deletions src/orb/resources/subscriptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -757,8 +757,8 @@ def fetch_costs(
self,
subscription_id: str,
*,
timeframe_end: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_end: Union[str, datetime] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime] | NotGiven = NOT_GIVEN,
view_mode: Optional[Literal["periodic", "cumulative"]] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand Down Expand Up @@ -2387,8 +2387,8 @@ async def fetch_costs(
self,
subscription_id: str,
*,
timeframe_end: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime, None] | NotGiven = NOT_GIVEN,
timeframe_end: Union[str, datetime] | NotGiven = NOT_GIVEN,
timeframe_start: Union[str, datetime] | NotGiven = NOT_GIVEN,
view_mode: Optional[Literal["periodic", "cumulative"]] | NotGiven = NOT_GIVEN,
# Use the following arguments if you need to pass additional parameters to the API that aren't available via kwargs.
# The extra values given here take precedence over values defined on the client or passed to this method.
Expand Down
4 changes: 2 additions & 2 deletions src/orb/types/customers/cost_list_by_external_id_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@


class CostListByExternalIDParams(TypedDict, total=False):
timeframe_end: Annotated[Union[str, datetime, None], PropertyInfo(format="iso8601")]
timeframe_end: Annotated[Union[str, datetime], PropertyInfo(format="iso8601")]
"""Costs returned are exclusive of `timeframe_end`."""

timeframe_start: Annotated[Union[str, datetime, None], PropertyInfo(format="iso8601")]
timeframe_start: Annotated[Union[str, datetime], PropertyInfo(format="iso8601")]
"""Costs returned are inclusive of `timeframe_start`."""

view_mode: Optional[Literal["periodic", "cumulative"]]
Expand Down
4 changes: 2 additions & 2 deletions src/orb/types/customers/cost_list_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@


class CostListParams(TypedDict, total=False):
timeframe_end: Annotated[Union[str, datetime, None], PropertyInfo(format="iso8601")]
timeframe_end: Annotated[Union[str, datetime], PropertyInfo(format="iso8601")]
"""Costs returned are exclusive of `timeframe_end`."""

timeframe_start: Annotated[Union[str, datetime, None], PropertyInfo(format="iso8601")]
timeframe_start: Annotated[Union[str, datetime], PropertyInfo(format="iso8601")]
"""Costs returned are inclusive of `timeframe_start`."""

view_mode: Optional[Literal["periodic", "cumulative"]]
Expand Down
4 changes: 2 additions & 2 deletions src/orb/types/subscription_fetch_costs_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@


class SubscriptionFetchCostsParams(TypedDict, total=False):
timeframe_end: Annotated[Union[str, datetime, None], PropertyInfo(format="iso8601")]
timeframe_end: Annotated[Union[str, datetime], PropertyInfo(format="iso8601")]
"""Costs returned are exclusive of `timeframe_end`."""

timeframe_start: Annotated[Union[str, datetime, None], PropertyInfo(format="iso8601")]
timeframe_start: Annotated[Union[str, datetime], PropertyInfo(format="iso8601")]
"""Costs returned are inclusive of `timeframe_start`."""

view_mode: Optional[Literal["periodic", "cumulative"]]
Expand Down