Skip to content

Add Msys2 building appveor #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2017
Merged

Add Msys2 building appveor #227

merged 2 commits into from
Sep 16, 2017

Conversation

alex85k
Copy link

@alex85k alex85k commented Sep 15, 2017

Following #224 and #226

Here is the build on Windows with latest MinGW compiler provided by MSYS2 project. The dependencies are also provied and downloaded as binary pacakages (may be updating, versions are not fixed).

I have also found a source of minor problem with not-finding json ruby gem - gem executable was called gem.cmd and was not found with FindGem.cmake.
With current version of MSYS2 packages all the tests should pass.

@codecov-io
Copy link

Codecov Report

Merging #227 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   91.45%   91.48%   +0.02%     
==========================================
  Files         258      258              
  Lines       18006    18006              
==========================================
+ Hits        16468    16472       +4     
+ Misses       1538     1534       -4
Flag Coverage Δ
#data_tests 79.48% <ø> (+0.08%) ⬆️
#examples 59.53% <ø> (+0.37%) ⬆️
#unit_tests 88.63% <ø> (+0.11%) ⬆️
Impacted Files Coverage Δ
include/osmium/thread/queue.hpp 100% <0%> (+12.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf6702...0a281c0. Read the comment docs.

@joto joto merged commit fc173da into osmcode:master Sep 16, 2017
@joto
Copy link
Member

joto commented Sep 16, 2017

I have merged this, thank you!

There are some warnings in the appveyor log about winsock2.h and windows.h. Do we need to do something there?

@alex85k
Copy link
Author

alex85k commented Sep 16, 2017

The best thing to do about that warnings is to eliminate winsock headers from pbf reader. The only need for them is htonl function here:

const uint32_t sz = htonl(static_cast_with_assert<uint32_t>(blob_header_data.size()));

Will make PR with this simplification (now that we have protozero with similar functionality)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants