Gracefully handle Contributor License Agreements #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor license agreements are fundamentally different from other licenses in ScanCode, as they are relevant only when contributing to source code but not for using the source code or its corresponding release artifacts. Prepare for handling CLA's completely separately, by re-assigning them to their own category. Note: Do not re-assign CLA's which are 'generic' or 'unknown' licenses, because such licenses do no even represent a real license and again need a special handling. Signed-off-by: Frank Viernau <[email protected]>
The generation logic has been changed to re-assign CLAs to their own category. Re-generate the file by using [1] to reflect that. [1] ./gradlew generateLicenseClassifications Signed-off-by: Frank Viernau <[email protected]>
CLAs do not need to be flagged, because they do not apply to the use of open source (only to contributing to it). Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
cla-handling
branch
from
1daa5cc to
7a4071d
Compare
tsteenbe
approved these changes
Nov 17, 2022
mnonnenmacher
approved these changes
Nov 17, 2022
| @@ -44,6 +44,19 @@ private val JSON_MAPPER = JsonMapper().apply { | |||
| propertyNamingStrategy = PropertyNamingStrategies.SNAKE_CASE | |||
| } | |||
|
|
|||
| private val CONTRIBUTOR_LICENSE_AGREEMENT_IDS = listOf( | |||
There was a problem hiding this comment.
Commit message nit: "CLA's" > "CLAs"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Context #66.
Note: I've proposed the corresponding extension of ScanCode's license data model here: aboutcode-org/scancode-toolkit#3147.