You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Found when looking into ota-meshi/jsonc-eslint-parser#184: this package's rules seem to completely ignore estree types, and instead replace node types with their own AST.JSON* types.
Would you be open to a PR that adds a few explicit call signatures that have a type for the RuleListener's node? We use this strategy in typescript-eslint to remove the need for most node: ... type annotations in our rules.
Would you be open to a PR that adds a few explicit call signatures that have a type for the RuleListener's node? We use this strategy in typescript-eslint to remove the need for most node: ... type annotations in our rules.
Thank you for posting the issue!
Yeah, I think it would be useful to have that type annotations. I think it would be useful if jsonc-eslint-parser provided type annotations so that each plugin would be easier to use.
Found when looking into ota-meshi/jsonc-eslint-parser#184: this package's rules seem to completely ignore
estree
types, and instead replace node types with their ownAST.JSON*
types.eslint-plugin-jsonc/lib/types.ts
Lines 3 to 5 in 247c013
eslint-plugin-jsonc/lib/rules/no-bigint-literals.ts
Line 25 in 247c013
Would you be open to a PR that adds a few explicit call signatures that have a type for the
RuleListener
'snode
? We use this strategy in typescript-eslint to remove the need for mostnode: ...
type annotations in our rules.In theory this could be automated with TypeScript type magicks. I haven't looked into it.
The text was updated successfully, but these errors were encountered: