You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is this ESTree<>JSONC types mismatch problem something that can be solved? If not, is there a workaround you'd recommend? And either way, could we document the answer?
For reference, it looks like the strategy in eslint-plugin-jsonc is to completely remove the built-in ESTree types?
Work in progress:
- [x] `npm run tsc` passes
- [x] `npm run test` passes (except for #60)
- [x] Filed docs issue on `jsonc-eslint-parser` to document how to work
effectively with ESTree:
ota-meshi/jsonc-eslint-parser#184Fixes#35.
Converts source files to TypeScript. In doing so, switches the test
library from Mocha to Vitest so that no transpiling is needed for tests.
~Will wait for feedback on
ota-meshi/eslint-plugin-jsonc#269 before taking
that PR's strategy in here.~ ✅ Brings in
ota-meshi/eslint-plugin-jsonc#271
`RuleListener` type as well.
~Marking as blocked on #60. I'd like that to be resolved before making
any changes that happen to also change tests around.~ ✅
👋 good news: https://github.com/JoshuaKGoldberg/eslint-plugin-package-json now uses
jsonc-eslint-parser
as of0.3.0
!Less good news: I'm having a bit of a hard time wrestling with TypeScript types trying to convert
eslint-plugin-package-json
to TypeScript in JoshuaKGoldberg/eslint-plugin-package-json#59. As noted in #159, theAST.JSON*
types fromjsonc-eslint-parser
aren't assignable to or fromESTree.*
types fromestree
. Example type assertions: https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/pull/59/files#diff-c14abd619a7569f9b82e00ce73302cacc0eca3d6462db5499652adeaf58c38faR36-R39Is this ESTree<>JSONC types mismatch problem something that can be solved? If not, is there a workaround you'd recommend? And either way, could we document the answer?
For reference, it looks like the strategy in
eslint-plugin-jsonc
is to completely remove the built-in ESTree types?RuleListener
type that only allowsnode: never
typesThe text was updated successfully, but these errors were encountered: