Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here webonyx/graphql-php#425, instantiating schemas with many types can hit performance. It was suggested (and implemented) to wrap field type definitions into a closure for lazy loading.
This PR updates the
TypeBuilder
class to generate proper field types. It wraps only user-defined types into a closure.Example:
Also some unused methods were removed from
TypeResolver
, asTypeGenerator
never generates references like this:but generates this instead: