Blocks above y=254 do not render

[jack-webb]

I think related to #1954, blocks at or above 255 aren't rendering on my 1.18 world. I'm using master a5b36f5. This also doesn't render below y=0

Render	In-game

[greatmastermario]

Looks like there are some hardcoded references to max height (formerly 255) and/or max y for sections. Section data can now go as low as -4 and as high as 19 (inclusive), so any references to these boundaries will need to be looked for. I am taking a look, and if I find all the references I will open a PR. If anyone can beat me to the punch please feel free

[greatmastermario]

#2012

I got the fix working. Also fixes Issue 1954

[arcctg]

@greatmastermario sorry to bother you. How I can use your bugfix/2003_1.18_Increased_Height with fixed render above 254 height to render my world?

[greatmastermario]

@Daanay After you check out my branch, you need to recompile the C libraries. Follow the instructions in the documentation to do this. I did it with Python 3.9 with option 2 for compiling, but you should be able to use whatever works for you and the platform you are compiling on. Once that's done, run as normal.

Also, my branch is on a fork, so you may need to clone my fork of the repo to access the branch. I've never tried to checkout from a fork before.

[arcctg]

Thank you so much!

[jobe1986]

This bug does make me wonder about custom dimension types, which if I read correctly can have Y coordinates ranging from -2032 to 2031 (looking at min_y and height from custom dimension types on https://minecraft.fandom.com/wiki/Custom_dimension?so=search#Dimension_type ) Though as yet I havent tested how accurate that info is on the available options.

[greatmastermario]

Since this issue was fixed with my PR and merged to the main branch, can we close this issue?