Soul lightning #1839
Soul lightning #1839
Conversation
crying_obsidian, lodestone, respawn_anchor ancient_debris part of the nether roof
| block_crimson_sign = 12505, | ||
| block_warped_sign = 12506, |
There was a problem hiding this comment.
Any particular reason for using high IDs for these and the wall signs? In general we should avoid high IDs because we create an array up to the highest block index, which increases memory usage if this is a new highest ID block.
overviewer_core/textures.py
Outdated
| if blockid == 51: | ||
| firetextures = self.load_fire() | ||
| side1 = self.transform_image_side(firetextures[0]) | ||
| side2 = self.transform_image_side(firetextures[1]).transpose(Image.FLIP_LEFT_RIGHT) | ||
| elif blockid == 1040: | ||
| soul_firetextures = self.load_soul_fire() | ||
| side1 = self.transform_image_side(soul_firetextures[0]) | ||
| side2 = self.transform_image_side(soul_firetextures[1]).transpose(Image.FLIP_LEFT_RIGHT) | ||
|
|
There was a problem hiding this comment.
I don't think you need to duplicate the transform code here.
firetextures = self.load_fire() if blockid == 51 else self.load_soul_fire()
side1 = self.transform_image_side(firetextures[0])
side2 = self.transform_image_side(firetextures[1]).transpose(Image.FLIP_LEFT_RIGHT)should be enough to handle both cases.
There was a problem hiding this comment.
Unless i completely missed something about the data parameter, this is always zero for both fire variants ( not 0 .. 15)
So this can be simplified to
# fire and soul_fire
@material(blockid=[51, 1040], transparent=True)
def fire(self, blockid, data):
if blockid == 51:
textureNS = self.load_image_texture("assets/minecraft/textures/block/fire_0.png")
textureEW = self.load_image_texture("assets/minecraft/textures/block/fire_1.png")
elif blockid == 1040:
textureNS = self.load_image_texture("assets/minecraft/textures/block/soul_fire_0.png")
textureEW = self.load_image_texture("assets/minecraft/textures/block/soul_fire_1.png")
side1 = self.transform_image_side(textureNS)
side2 = self.transform_image_side(textureEW).transpose(Image.FLIP_LEFT_RIGHT)
img = Image.new("RGBA", (24,24), self.bgcolor)
alpha_over(img, side1, (12,0), side1)
alpha_over(img, side2, (0,0), side2)
alpha_over(img, side1, (0,6), side1)
alpha_over(img, side2, (12,6), side2)
return imgOr am I missing something?
| 509: "assets/minecraft/textures/block/crimson_planks.png", | ||
| 510: "assets/minecraft/textures/block/warped_planks.png", |
There was a problem hiding this comment.
why are these at 500 as opposed to 1000? not that it really matters, just wondering if there's something you were planning on doing with that
There was a problem hiding this comment.
These are the block IDs that minecraft uses itself. Only in bedrock these days, but I thought it was best to just continue the existing pattern.
|
Added the changes for soul fire texture loading |
Add soul_fire, soul_lanterns and soul_torch
included PRs: #1835 and #1832 , I close this.
Related Issue: #1807