Skip to content

Fixed edge-lines and side rendering for snow layers #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

buscher
Copy link
Contributor

@buscher buscher commented Jul 15, 2021

Fix "dirty" snow, because of wrong edge-lines and missing texture side darkening.

Pretty hard so see in game, but for comparison, In-Game:
dirty_snow_ingame

Current master (without the fix):
dirty_snow

With the fix:
dirty_snow_fixed

@generrosity
Copy link

Applogies for the query, but wondering @buscher if part of the the 'edges' you fixing was these other visual gaps and alignments? Althought at a tight zoom of your fix, I suspect it is unrelated and I can log a new Issue for it

image
image

@buscher
Copy link
Contributor Author

buscher commented Jul 23, 2021

I can see the issues you are talking about. But yes, I did not touch this part of the code.
I will have to touch this code part again after adding powder_snow, then maybe I will look deeper into it and see if I can fix it, but this will have to come laaaaaaater, got lots of other stuff on my TODO list first :)

@CounterPillow CounterPillow merged commit 08e628c into overviewer:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants