Skip to content

Add compatibility for 21w39a and 21w43a snapshots #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

26
Copy link
Contributor

@26 26 commented Nov 7, 2021

This pull request adds basic compatibility for 21w39a and 21w43a. In both these snapshots, changes were made to the way chunks are stored on disk.

It does not yet implement paletted biome's and I have not fully tested everything yet. However, a good-looking world seems to come out when I try to render a world created in 21w44a.

This pull request should fix #1982.

@26 26 changed the title Add compatibility for post 21w39a and 21w43a snapshots Add compatibility for 21w39a and 21w43a snapshots Nov 7, 2021
@26
Copy link
Contributor Author

26 commented Nov 10, 2021

I have tested this on a much larger world. The result can be seen on https://poldercraft.nl/renders/world_141121/. I think this is ready now.

@26 26 marked this pull request as ready for review November 10, 2021 19:38
@Hackaloken
Copy link

Hackaloken commented Nov 30, 2021

I just started up a vanilla 1.18 server; this fixed map generation for me 👍

@spacegriffin
Copy link

Does this also fix rendering for the new generation under y=0?

Copy link

@F-Node-Karlsruhe F-Node-Karlsruhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgently needed fix for 1.18 release

@bagobones
Copy link

Would appreciate this for minimum support. Our player group is really excited about 1.18 since so much has changed.

@BenKennish
Copy link

Can this be accepted please so that I can run a render for my 1.18 world?

@BenKennish
Copy link

OK so the players on my server are getting impatient to see the rendered map for the new 1.18 world. It's been a while since I did anything more than the basics with git so can someone advise me on how to get this code working on my server but in such a way that I can still upgrade to the latest official version of Overviewer when it's released (possibly with this PR or a variation of it)?

@elboletaire
Copy link

OK so the players on my server are getting impatient to see the rendered map for the new 1.18 world. It's been a while since I did anything more than the basics with git so can someone advise me on how to get this code working on my server but in such a way that I can still upgrade to the latest official version of Overviewer when it's released (possibly with this PR or a variation of it)?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating blank tiles when rendering 21w37a/21w38a snapshot
9 participants