Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sap): add installation dashboard page #16363

Open
wants to merge 1 commit into
base: feat/sap-features-hub
Choose a base branch
from

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Apr 2, 2025

Description

Ticket Reference: #MANAGER-17205

Additional Information

✋ WAIT : #16375 and #16376

@tibs245 tibs245 force-pushed the feat/sap-installation-dashboard branch from d87b729 to cc5adb7 Compare April 3, 2025 10:24
@tibs245 tibs245 marked this pull request as ready for review April 3, 2025 10:24
@tibs245 tibs245 requested a review from a team as a code owner April 3, 2025 10:24
@tibs245 tibs245 requested review from helabenkhalfallah and anooparveti and removed request for a team April 3, 2025 10:25
@tibs245 tibs245 force-pushed the feat/sap-installation-dashboard branch from cc5adb7 to 1e432d7 Compare April 3, 2025 13:54
ref: #MANAGER-17205

Signed-off-by: Thibault Barske <[email protected]>
@tibs245 tibs245 force-pushed the feat/sap-installation-dashboard branch from 1e432d7 to 250ce7f Compare April 3, 2025 15:32
Copy link

sonarqubecloud bot commented Apr 3, 2025

Copy link
Contributor

@pauldkn pauldkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some filenames are not really compliant with manager guidelines
  • Some tests are failing
  • Build is failing
  • 7 SonarCloud new issues

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we're supposed to have pages named index.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants