Merge pull request #733 from beluc/resource_iploadbalancing_ssl

fix definition of ovh_iploadbalancing_ssl

Author: amstuta

ovh/resource_iploadbalancing_ssl_gen.go

@@ -9,7 +9,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
 )
 
-const certificate = `
+const crt1 = `
 -----BEGIN CERTIFICATE-----
 MIIDnzCCAoegAwIBAgIUchdtmNBNsdO0rJFBZEr14/5zAe4wDQYJKoZIhvcNAQEL
 BQAwXzELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoM
@@ -34,7 +34,7 @@ TOP9quQjYN/Q8Q+sMud9sDFeKA==
 -----END CERTIFICATE-----
 `
 
-const key = `
+const key1 = `
 -----BEGIN PRIVATE KEY-----
 MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQDYw2EmScl7ra9R
 6Fi7NxEVQLdeHcvi3kfZmoPFaWgHpJSnMiECZe2OYC93BN90Hw17n6lo6OSLX/0d
@@ -65,6 +65,62 @@ s9niPsoEYo3+0dm/OhJymKKD
 -----END PRIVATE KEY-----
 `
 
+const crt2 = `
+-----BEGIN CERTIFICATE-----
+MIIDnzCCAoegAwIBAgIUfFQedAHR39RYsu38ubdwgQFVYpEwDQYJKoZIhvcNAQEL
+BQAwXzELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoM
+GEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDEYMBYGA1UEAwwPd3d3LmV4YW1wbGUu
+Y29tMB4XDTI0MDkyNzA5MDY1MVoXDTI1MDkyNzA5MDY1MVowXzELMAkGA1UEBhMC
+QVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGEludGVybmV0IFdpZGdp
+dHMgUHR5IEx0ZDEYMBYGA1UEAwwPd3d3LmV4YW1wbGUuY29tMIIBIjANBgkqhkiG
+9w0BAQEFAAOCAQ8AMIIBCgKCAQEAwWKsvwGKSMLYBU0MDPN+I7lUcFZowMh7XL2Y
+fYKypDt23bzBcBzY0vgJJFYA74WG28Djv2VRTTOpho0eYJ1vt2ap6A3uID8xyQc8
+Bocwaaws0b24cn0KShagW71XW2ZXI1gZIwRvaJK18hxqkdS5+Nv/CfE46+wrW9GG
+9RAF1E/C3+mJq79hjH0bdHDwic91x/cEw8K+CQlZXbtQyPdl9SV398ccfcQ602iv
+VcXIOs5OD0YAXkyoeJKpe182Z6BrsqNJanEa0kMXSgyCcGHIaB5HUpCrRW9v4Xgy
+vQwoim1iyOonpqUWFtXKM06OiwypJaj6HJAZTvYvbkO9ibURFQIDAQABo1MwUTAd
+BgNVHQ4EFgQUvQQRWOJazR1pWoIQZnPPe7o7d+IwHwYDVR0jBBgwFoAUvQQRWOJa
+zR1pWoIQZnPPe7o7d+IwDwYDVR0TAQH/BAUwAwEB/zANBgkqhkiG9w0BAQsFAAOC
+AQEAJ9Uf31Ttcfw7GfsZunYRwt3hMROqp5PFJ/RfYfQ4jUfhuvRG/Dl3OUuiDhCc
+ny+jtcitJvghNBwtWRZCLIozsjYz/Ve6khgzU/s4OeR0dxtQAOMynxp6j6ENFjmW
+35lelGHT70ClCvksRpZsIIaVIxahPi3T8FAUuyOZhfLSzAQXvLXH8xz1KmllzDew
+H9lNBcmUPM7NwFCsBbH5JkbghCiD7cWPltMgZG3fCvDjAvhTkbpieeElrUD1t0CZ
+vnmJN5F9yb1QPeeOCsRYVffnAvFuh88x9Xbe/h+G8S1KW+AR8PM64U/V7GiXKcsW
+jeTEd26AdLKSb9blbQRooXK8+A==
+-----END CERTIFICATE-----
+`
+
+const key2 = `
+-----BEGIN PRIVATE KEY-----
+MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQDBYqy/AYpIwtgF
+TQwM834juVRwVmjAyHtcvZh9grKkO3bdvMFwHNjS+AkkVgDvhYbbwOO/ZVFNM6mG
+jR5gnW+3ZqnoDe4gPzHJBzwGhzBprCzRvbhyfQpKFqBbvVdbZlcjWBkjBG9okrXy
+HGqR1Ln42/8J8Tjr7Ctb0Yb1EAXUT8Lf6Ymrv2GMfRt0cPCJz3XH9wTDwr4JCVld
+u1DI92X1JXf3xxx9xDrTaK9Vxcg6zk4PRgBeTKh4kql7XzZnoGuyo0lqcRrSQxdK
+DIJwYchoHkdSkKtFb2/heDK9DCiKbWLI6iempRYW1cozTo6LDKklqPockBlO9i9u
+Q72JtREVAgMBAAECggEAUaLoLdHmoISwULyPw7/elhIclTfFDO0VNrdK8mEELNR1
+f3G5byyeU6ElqtMrnfGOVqJ9AkUxJxgSDpzwH/UWPiP2weFvjuleiPCm5FKZm2J1
+oS0n+hzTBSe8Fj497HWtf1wncGLk7Q5SBJz+WAWnZGjqpzXPw7h1LVOsVzOmYlN1
+OIYiN9TJx69GjQZ7q8mPhxmbQGznX3yMKHzpeVJrKs6GaOkFJPsJpNXaqnw/ukZB
+IOmkX3Lh89RHZtWOl2J2TZO75d5Eo0UptX+xanDSWSiHGFiFltl//EPIF61gaOUb
+6zv5MdPLGBz2DEIKPt9DHL+Y6pO42d5yDyZVIaSCmQKBgQDt0tLCzLyPQsj9pnuq
++XRmT5X5uosKZBm9j6JcH6AN/uA0OffbMnkU2mM8W18bboU5N02G3UlIegyciFIu
+7Q56CqtizU8WEkbVNMT9x0njE08o6b13VfJpe317kiJkxDpaarDG35rlBLn5NbMX
+Lz2+Pvi93Ghq5MlnFBtF6KkuOwKBgQDQKmQEF0LptnTSdj8RsBB8VnI7fFOOS2vA
+2G7FQ6YtOB6TKG4+Xr3+Y3mjKnQzhS8MYBjZW30r7c9mGnE6gsu0nxW89ZxcMoFY
+/O4t07FrDyk+Mgylxk0o11CsvCgmNSZsGKQLnNFB22JvgXvMCSm14UcoodOE6JSk
+P/MEnJI47wKBgQDjms3scsbPEKqM3sUiV0UIGYi+DMK+uhhMa+eF5Rpn6pKmSQgl
+twNcarlobUXzWe2UWZIPzT4yZ+Qj9u84S9V8BTQLBdR3mhxCNhOFkTHsaXFsBW83
+g4DRZMct+SiDaa0zFUKDwkJahhB6KeNw/9xGc7vY8NTZ4IXD6eFEIauwOwKBgQC7
+8Snvz5ioLgV3Zy82JwIbYGkub+d4l3un10DbdWJ5fSuNrXkrcpqTLPjLai8TvPFn
+ePO2erWejc0s4D7OlvyYDPGxcwdC7o59646XbYPHpx6TetiUa1+KuiuqaQ7OwDn6
+apzhpyn/DbXn+r3sz3ELN2PpuYGhg+OAEAS3ay1RnQKBgGpx5KLTpbbv4OKSStkA
+JgoHXUxZ8ZkDKHd/HikI8q5inplE1v6hjxzdbOLfNCZmsmLN3Lr7zY3V2+KrVNJw
+W81qUpgbMTA6TozkgsaS6EuXqPG/iaS6iAu3KBqthzDXeTJqH6kkDFuYuzQK6Egg
+AvulFF6dizi0pVFg/H84rN2n
+-----END PRIVATE KEY-----
+`
+
 const testAccCheckOvhIpLoadbalancingSslConfig = `
 resource "ovh_iploadbalancing_ssl" "testssl" {
 	service_name = "%s"
@@ -89,29 +145,42 @@ func TestAccIpLoadbalancingSsl_basic(t *testing.T) {
 		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
 		Steps: []resource.TestStep{
 			{
-				Config: fmt.Sprintf(testAccCheckOvhIpLoadbalancingSslConfig, iplb, "aaa", certificate, key, certificate),
+				Config: fmt.Sprintf(testAccCheckOvhIpLoadbalancingSslConfig, iplb, "aaa", crt1, key1, crt1),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr(
 						"ovh_iploadbalancing_ssl.testssl", "display_name", "aaa"),
 					resource.TestCheckResourceAttr(
-						"ovh_iploadbalancing_ssl.testssl", "certificate", fmt.Sprintf("%s\n", certificate)),
+						"ovh_iploadbalancing_ssl.testssl", "certificate", fmt.Sprintf("%s\n", crt1)),
 					resource.TestCheckResourceAttr(
-						"ovh_iploadbalancing_ssl.testssl", "key", fmt.Sprintf("%s\n", key)),
+						"ovh_iploadbalancing_ssl.testssl", "key", fmt.Sprintf("%s\n", key1)),
 					resource.TestCheckResourceAttr(
-						"ovh_iploadbalancing_ssl.testssl", "chain", fmt.Sprintf("%s\n", certificate)),
+						"ovh_iploadbalancing_ssl.testssl", "chain", fmt.Sprintf("%s\n", crt1)),
 				),
 			},
 			{
-				Config: fmt.Sprintf(testAccCheckOvhIpLoadbalancingSslConfig, iplb, "bbb", certificate, key, certificate),
+				Config: fmt.Sprintf(testAccCheckOvhIpLoadbalancingSslConfig, iplb, "bbb", crt1, key1, crt1),
 				Check: resource.ComposeTestCheckFunc(
 					resource.TestCheckResourceAttr(
 						"ovh_iploadbalancing_ssl.testssl", "display_name", "bbb"),
 					resource.TestCheckResourceAttr(
-						"ovh_iploadbalancing_ssl.testssl", "certificate", fmt.Sprintf("%s\n", certificate)),
+						"ovh_iploadbalancing_ssl.testssl", "certificate", fmt.Sprintf("%s\n", crt1)),
+					resource.TestCheckResourceAttr(
+						"ovh_iploadbalancing_ssl.testssl", "key", fmt.Sprintf("%s\n", key1)),
+					resource.TestCheckResourceAttr(
+						"ovh_iploadbalancing_ssl.testssl", "chain", fmt.Sprintf("%s\n", crt1)),
+				),
+			},
+			{
+				Config: fmt.Sprintf(testAccCheckOvhIpLoadbalancingSslConfig, iplb, "ccc", crt2, key2, crt2),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(
+						"ovh_iploadbalancing_ssl.testssl", "display_name", "ccc"),
+					resource.TestCheckResourceAttr(
+						"ovh_iploadbalancing_ssl.testssl", "certificate", fmt.Sprintf("%s\n", crt2)),
 					resource.TestCheckResourceAttr(
-						"ovh_iploadbalancing_ssl.testssl", "key", fmt.Sprintf("%s\n", key)),
+						"ovh_iploadbalancing_ssl.testssl", "key", fmt.Sprintf("%s\n", key2)),
 					resource.TestCheckResourceAttr(
-						"ovh_iploadbalancing_ssl.testssl", "chain", fmt.Sprintf("%s\n", certificate)),
+						"ovh_iploadbalancing_ssl.testssl", "chain", fmt.Sprintf("%s\n", crt2)),
 				),
 			},
 		},
@@ -126,7 +195,7 @@ func TestAccIpLoadbalancingSsl_importBasic(t *testing.T) {
 		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
 		Steps: []resource.TestStep{
 			{
-				Config: fmt.Sprintf(testAccCheckOvhIpLoadbalancingSslConfig, iplb, "aaa", certificate, key, certificate),
+				Config: fmt.Sprintf(testAccCheckOvhIpLoadbalancingSslConfig, iplb, "aaa", crt1, key1, crt1),
 			},
 			{
 				ResourceName:            "ovh_iploadbalancing_ssl.testssl",

ovh/resource_iploadbalancing_ssl_test.go

@@ -20,6 +20,11 @@ resource "ovh_iploadbalancing_ssl" "sslname" {
   certificate  = "..."
   key          = "..."
   chain        = "..."
+
+  # use this if ssl is configured as frontend default_ssl
+  lifecycle {
+    create_before_destroy = true
+  }
 }
 ```