fix definition of ovh_iploadbalancing_ssl #733
Conversation
beluc
requested review from
rbeuque74,
deathiop,
amstuta,
mxpetit,
yomovh and
marie-j
as code owners
|
There is still an issue on imported certificates, as the API only returns fingerprint, not the cert/chain/key values some ideas to fix :
|
|
maybe we can deal with fingerprint using https://developer.hashicorp.com/terraform/plugin/framework/resources/plan-modification#requiresreplaceif |
this do the job ! |
beluc
force-pushed
the
resource_iploadbalancing_ssl
branch
3 times, most recently
from
3bffa9c to
e9f5640
Compare
| @@ -20,6 +20,11 @@ resource "ovh_iploadbalancing_ssl" "sslname" { | |||
| certificate = "..." | |||
| key = "..." | |||
| chain = "..." | |||
|
|
|||
| # use this if ssl is configured as frontend default_ssl | |||
There was a problem hiding this comment.
is this really needed now that you added several RequireReplace on the fields ?
There was a problem hiding this comment.
is this really needed now that you added several
RequireReplaceon the fields ?
As we cant remove a ssl object if it's used as default ssl on a frontend, the create_before_destroy option is needed
|
|
||
| if buf.String() == data.Fingerprint.ValueString() { | ||
| // This ssl was created from a CERT/KEY/CHAIN but it's gone from the state. | ||
| // This happen when we import this ressource, |
There was a problem hiding this comment.
| // This happen when we import this ressource, | |
| // This happens when we import this ressource, |
beluc
force-pushed
the
resource_iploadbalancing_ssl
branch
from
e9f5640 to
c40d426
Compare
Description
ovh_iploadbalancing_ssl: Changing service_name, certificate, key or chain must trigger a full replace
Type of change
How Has This Been Tested?
make testacc TESTARGS="-run TestAccIpLoadbalancingSsl_basic"make testacc TESTARGS="-run TestAccIpLoadbalancingSsl_importBasic"Checklist:
go mod vendorif I added or modifygo.modfile