Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect API path in resource naming #23

Closed
goblain opened this issue May 10, 2018 · 1 comment
Closed

Reflect API path in resource naming #23

goblain opened this issue May 10, 2018 · 1 comment

Comments

@goblain
Copy link
Contributor

goblain commented May 10, 2018

It would seem reasonable to keep names of resources a bit more in line with what can be found in OVH API.
For example, considering the URI in OVH API is
/cloud/project/{serviceName}/network/private/{networkId}/subnet
the resource name for private networks subnet would be
ovh_cloud_network_private_subnet
instead of
ovh_publiccloud_private_network_subnet

I could adapt that keeping previous naming for backward compatibility. It would also provide a clear guideline on how to name new resources.

goblain added a commit to goblain/terraform-provider-ovh that referenced this issue May 14, 2018
goblain added a commit to goblain/terraform-provider-ovh that referenced this issue May 14, 2018
goblain added a commit to goblain/terraform-provider-ovh that referenced this issue May 17, 2018
goblain added a commit to goblain/terraform-provider-ovh that referenced this issue May 17, 2018
goblain added a commit to goblain/terraform-provider-ovh that referenced this issue May 17, 2018
yanndegat added a commit that referenced this issue May 22, 2018
adds new resource names following issue #23 outlines
@yanndegat
Copy link
Collaborator

released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants