Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle record id bigger than 32bits #109

Merged
merged 2 commits into from
Nov 26, 2019
Merged

handle record id bigger than 32bits #109

merged 2 commits into from
Nov 26, 2019

Conversation

kerwanp
Copy link

@kerwanp kerwanp commented Nov 25, 2019

The OvhDomainZoneRecordImportState can have an Id bigger than 32 bits.
I did this temporary fix for my own use, and created the pull request to open the conversation.

I'm not a Go developer and just made this to continue working.

@ghost ghost added the size/XS label Nov 25, 2019
@yanndegat
Copy link
Collaborator

hi @kerwanp

thanks a lot for this fix. i ran the testacc and it's a green.
i think we may have the issue elsewhere so i'll log an issue to check that all API mapped "long" attributes are correctly mapped with int64 go types

@yanndegat yanndegat merged commit 3a6fc81 into ovh:master Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants