-
Notifications
You must be signed in to change notification settings - Fork 154
Feat/add redirect location to ovh_iploadbalancing_http_frontend #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add redirect_location to ovh_iploadbalancing_http_frontend
7ae6fe7
to
d0e93a5
Compare
cf9f477
to
bdcda64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with @yanndegat maybe we don't need to change the string
to *string
on RedirectLocation and we can add a test later on to see if it is needed or not.
The two indentation problems have likely been introduced by your conflict resolution @yanndegat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, lgtm
Feat/add redirect location to ovh_iploadbalancing_http_frontend
Issue