Skip to content

Feat/add redirect location to ovh_iploadbalancing_http_frontend #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2020

Conversation

DamienJ-wiza
Copy link
Contributor

@yanndegat yanndegat force-pushed the master branch 9 times, most recently from 7ae6fe7 to d0e93a5 Compare August 28, 2020 21:37
@yanndegat yanndegat force-pushed the master branch 2 times, most recently from cf9f477 to bdcda64 Compare November 18, 2020 13:56
@yanndegat yanndegat self-requested a review November 26, 2020 09:14
Copy link
Member

@pgaxatte pgaxatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @yanndegat maybe we don't need to change the string to *string on RedirectLocation and we can add a test later on to see if it is needed or not.

The two indentation problems have likely been introduced by your conflict resolution @yanndegat

@yanndegat yanndegat requested a review from pgaxatte November 26, 2020 09:22
Copy link
Member

@pgaxatte pgaxatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, lgtm

@yanndegat yanndegat merged commit ea43fe1 into ovh:master Nov 26, 2020
pascalinthecloud pushed a commit to pascalinthecloud/terraform-provider-ovh that referenced this pull request Apr 30, 2025
Feat/add redirect location to ovh_iploadbalancing_http_frontend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants