d|r/cloud*: use service_name for identifier #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanndegat
force-pushed
the
bigrefacto
branch
2 times, most recently
from
3a26591 to
776546e
Compare
pgaxatte
suggested changes
Nov 27, 2020
Comment on lines
27
to
36
| DefaultFunc: schema.EnvDefaultFunc("OVH_VRACK_ID", nil), | ||
| Description: "Id of the vrack. DEPRECATED, use `service_name` instead", | ||
| ConflictsWith: []string{"service_name"}, | ||
| }, | ||
| "service_name": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ForceNew: true, | ||
| DefaultFunc: schema.EnvDefaultFunc("OVH_VRACK", nil), |
There was a problem hiding this comment.
Is it intended to have two different env vars OVH_VRACK_ID and OVH_VRACK here?
There was a problem hiding this comment.
And shouldn't it be OVH_VRACK_SERVICE?
Comment on lines
27
to
36
| DefaultFunc: schema.EnvDefaultFunc("OVH_VRACK_ID", nil), | ||
| Description: "Id of the vrack. DEPRECATED, use `service_name` instead", | ||
| ConflictsWith: []string{"service_name"}, | ||
| }, | ||
| "service_name": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, | ||
| ForceNew: true, | ||
| DefaultFunc: schema.EnvDefaultFunc("OVH_VRACK", nil), |
There was a problem hiding this comment.
Same comment as in ovh/resource_ovh_vrack_dedicated_server.go
yanndegat
force-pushed
the
bigrefacto
branch
from
776546e to
43cbe0e
Compare
pgaxatte
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.