add adv oidc parameters #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, is it possible, in the documentation, for the resource, to have a simple example, the simplest one, to create an kube oidc resource, and another more complete (in order to know a concrete example for every fields)? Thanks :) |
|
Moreover, is it possible to add the possibility to import an oidc resource? |
scraly
requested changes
Nov 21, 2022
| } | ||
|
|
||
| output "oidc-val" { | ||
| value = data.ovh_cloud_project_kube_iprestrictions.oidc.client_id |
There was a problem hiding this comment.
Suggested change
| value = data.ovh_cloud_project_kube_iprestrictions.oidc.client_id | |
| value = data.ovh_cloud_project_kube_oidc.oidc.client_id |
ovh/data_cloud_project_kube_oidc.go
Outdated
| endpoint := fmt.Sprintf("/cloud/project/%s/kube/%s/openIdConnect", serviceName, kubeId) | ||
| res := &CloudProjectKubeOIDCResponse{} | ||
|
|
||
| log.Printf("[DEBUG] Will read oidc from kube %s and project: %s", kubeId, serviceName) |
There was a problem hiding this comment.
Suggested change
| log.Printf("[DEBUG] Will read oidc from kube %s and project: %s", kubeId, serviceName) | |
| log.Printf("[DEBUG] Will read OIDC from kube %s and project: %s", kubeId, serviceName) |
ovh/data_cloud_project_kube_oidc.go
Outdated
| } | ||
| d.SetId(kubeId + "-" + res.ClientID + "-" + res.IssuerUrl) | ||
|
|
||
| log.Printf("[DEBUG] Read oidc %+v", res) |
There was a problem hiding this comment.
Suggested change
| log.Printf("[DEBUG] Read oidc %+v", res) | |
| log.Printf("[DEBUG] Read OIDC %+v", res) |
| Config: config, | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr( | ||
| "data.ovh_cloud_project_kube_oidc.oidcData", "client_id", "toto"), |
There was a problem hiding this comment.
Suggested change
| "data.ovh_cloud_project_kube_oidc.oidcData", "client_id", "toto"), | |
| "data.ovh_cloud_project_kube_oidc.oidcData", "client_id", "my-oidc-client-id"), |
| service_name = ovh_cloud_project_kube.cluster.service_name | ||
| kube_id = ovh_cloud_project_kube.cluster.id | ||
|
|
||
| client_id = "toto" |
There was a problem hiding this comment.
Suggested change
| client_id = "toto" | |
| client_id = "my-oidc-client-id" |
|
scraly
requested changes
Nov 21, 2022
matprig
force-pushed
the
feat/oidc-adv-param
branch
from
15584ca to
5d0de3f
Compare
|
of course agree |
resource oidc data oidc test acceptance doc
matprig
force-pushed
the
feat/oidc-adv-param
branch
from
5d0de3f to
db1dc2f
Compare
scraly
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resource oidc
data oidc
test acceptance
doc