-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Database kafka schema registry #449
Merged
scraly
merged 12 commits into
ovh:master
from
BellionBastien:dev/bbellion/add-database-kafka-schema-registry
Aug 18, 2023
Merged
Add Database kafka schema registry #449
scraly
merged 12 commits into
ovh:master
from
BellionBastien:dev/bbellion/add-database-kafka-schema-registry
Aug 18, 2023
+750
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatte
approved these changes
Aug 8, 2023
scraly
requested changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new feature is working, thanks! :-)
Just some remarks, typos and few changes requested.
website/docs/r/cloud_project_database_kafka_schemaregistryacl.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_project_database_kafka_schemaregistryacl.html.markdown
Outdated
Show resolved
Hide resolved
Co-authored-by: Aurelie Vache <[email protected]>
…html.markdown Co-authored-by: Aurelie Vache <[email protected]>
…html.markdown Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
Co-authored-by: Aurelie Vache <[email protected]>
scraly
approved these changes
Aug 18, 2023
Thanks, it's OK for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding resource and datasource for newly implemented schema registry ACL on kafka databases.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaSchemaregistryacl_basic"
make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaSchemaregistryaclsDataSource_basic"
Checklist:
go mod vendor
if I added or modifygo.mod
file