Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iam_resourcegroup data and resources #457

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

fehrnah
Copy link
Contributor

@fehrnah fehrnah commented Aug 25, 2023

Description

Add support for IAM resource groups.

Resource groups are a collection of resources that can be used when writing policies.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

I have done local tests of both the resource and datadources, but I am not sure how I should go for writing acceptance tests, sin I need other resources to put in a group.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@fehrnah
Copy link
Contributor Author

fehrnah commented Aug 28, 2023

This is set as a draft because I don't know how to write the acceptance tests for the resources/datasources since I need to have at least one OVH service to be able to create a resource group.

It looks like some OVH services are given as environment variables. Can I use them here ? Or should I create new ones ?

@fehrnah
Copy link
Contributor Author

fehrnah commented Sep 4, 2023

This is set as a draft because I don't know how to write the acceptance tests for the resources/datasources since I need to have at least one OVH service to be able to create a resource group.

It looks like some OVH services are given as environment variables. Can I use them here ? Or should I create new ones ?

Ok, I've talked with people and I am adding test using resources provided in environment variables.

@fehrnah fehrnah marked this pull request as ready for review September 4, 2023 15:12
@fehrnah fehrnah force-pushed the dev/nfournie/resource-groups branch 7 times, most recently from ece1a2f to 63c5616 Compare September 5, 2023 12:43
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh ovh deleted a comment from ovh-cds Sep 5, 2023
@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 17, 2023

CDS Report terraform-provider-ovh-testacc#2094.0 ✘
*

  • checks ✘

@Stoakes
Copy link
Member

Stoakes commented Oct 30, 2023

@yomovh @rbeuque74 changes have been done. This PR ready to be reviewed again.

Copy link
Contributor

@yomovh yomovh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update in the documentation OK for me. @rbeuque74 can you check you remarks please ?

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 7, 2023

CDS Report terraform-provider-ovh-testacc#2094.1 ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 7, 2023

CDS Report terraform-provider-ovh-testacc#2094.1 ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 7, 2023

CDS Report terraform-provider-ovh-check#2094.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 7, 2023

CDS Report terraform-provider-ovh-testacc#2094.2 ✘
*

  • checks ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-testacc#2094.3 ✘
*

  • checks ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-check#2136.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-testacc#2136.0 ✔
*

  • checks ✔

@fehrnah fehrnah force-pushed the dev/nfournie/resource-groups branch from f1c9407 to e70d98c Compare November 8, 2023 16:14
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-check#2137.0 ✔
*

  • checks ✔

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-check#2137.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-check#2138.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-testacc#2137.0 ■
*

  • checks ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-testacc#2137.0 ■
*

  • checks ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-check#2138.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-testacc#2138.0 ■
*

  • checks ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-testacc#2138.0 ■
*

  • checks ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-check#2139.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 8, 2023

CDS Report terraform-provider-ovh-testacc#2139.0 ✔
*

  • checks ✔

@amstuta amstuta requested review from rbeuque74 and yomovh November 8, 2023 16:23
@fehrnah fehrnah merged commit 8b54466 into master Nov 13, 2023
@fehrnah fehrnah deleted the dev/nfournie/resource-groups branch November 13, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants