-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iam_resourcegroup data and resources #457
Conversation
This is set as a draft because I don't know how to write the acceptance tests for the resources/datasources since I need to have at least one OVH service to be able to create a resource group. It looks like some OVH services are given as environment variables. Can I use them here ? Or should I create new ones ? |
Ok, I've talked with people and I am adding test using resources provided in environment variables. |
ece1a2f
to
63c5616
Compare
CDS Report terraform-provider-ovh-testacc#2094.0 ✘
|
@yomovh @rbeuque74 changes have been done. This PR ready to be reviewed again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update in the documentation OK for me. @rbeuque74 can you check you remarks please ?
CDS Report terraform-provider-ovh-testacc#2094.1 ■ |
1 similar comment
CDS Report terraform-provider-ovh-testacc#2094.1 ■ |
CDS Report terraform-provider-ovh-check#2094.0 ✔
|
CDS Report terraform-provider-ovh-testacc#2094.2 ✘
|
CDS Report terraform-provider-ovh-testacc#2094.3 ✘
|
CDS Report terraform-provider-ovh-check#2136.0 ✔
|
CDS Report terraform-provider-ovh-testacc#2136.0 ✔
|
f1c9407
to
e70d98c
Compare
CDS Report terraform-provider-ovh-check#2137.0 ✔
|
1 similar comment
CDS Report terraform-provider-ovh-check#2137.0 ✔
|
CDS Report terraform-provider-ovh-check#2138.0 ✔
|
CDS Report terraform-provider-ovh-testacc#2137.0 ■
|
1 similar comment
CDS Report terraform-provider-ovh-testacc#2137.0 ■
|
CDS Report terraform-provider-ovh-check#2138.0 ✔
|
CDS Report terraform-provider-ovh-testacc#2138.0 ■
|
1 similar comment
CDS Report terraform-provider-ovh-testacc#2138.0 ■
|
CDS Report terraform-provider-ovh-check#2139.0 ✔
|
CDS Report terraform-provider-ovh-testacc#2139.0 ✔
|
Description
Add support for IAM resource groups.
Resource groups are a collection of resources that can be used when writing policies.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have done local tests of both the resource and datadources, but I am not sure how I should go for writing acceptance tests, sin I need other resources to put in a group.
Checklist:
go mod vendor
if I added or modifygo.mod
file