Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add display_name to datasource ovh_dedicated_server #581

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

amstuta
Copy link
Collaborator

@amstuta amstuta commented Mar 15, 2024

Description

Closes #431

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Test A: make testacc TESTARGS="-run TestAccDedicatedServerDataSource_basic"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

deathiop
deathiop previously approved these changes Mar 15, 2024
mxpetit
mxpetit previously approved these changes Mar 15, 2024
@amstuta amstuta dismissed stale reviews from mxpetit and deathiop via b835cec March 15, 2024 15:30
@amstuta amstuta force-pushed the dev/aamstutz/add-dedicated-server-display-name branch from cf9696d to b835cec Compare March 15, 2024 15:30
@amstuta amstuta merged commit fe66c01 into master Mar 15, 2024
@rbeuque74 rbeuque74 deleted the dev/aamstutz/add-dedicated-server-display-name branch March 18, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add displayName to ovh_dedicated_server
4 participants