fix kafka + add kafka_schema_registry attribute #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatte
requested review from
rbeuque74,
deathiop,
a-beudin,
amstuta,
mxpetit and
yomovh
as code owners
amstuta
reviewed
Apr 19, 2024
| opts.Backups = CloudProjectDatabaseBackups{ | ||
| Regions: regions, | ||
| Time: d.Get("backup_time").(string), | ||
| if engine != "kafka" && (len(regions) != 0 || time != "") { |
There was a problem hiding this comment.
not the same check as in CloudProjectDatabaseCreateOpts.fromResource ? (no engine != "kafka" there)
There was a problem hiding this comment.
backups field is ignored for a lot of engine in API (because the engine has not backup or backup not configurable) in POST and PUT, Kafka is the only engine where the schema of the PUT do not has backups fields. So this engine != "kafka" will ignore backups attribute for Kafka when update, no need to add this in CloudProjectDatabaseCreateOpts.fromResource because our API already ignore this field
amstuta
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backupsfield, this is a corner case of the resourceovh_cloud_project_databaseFixe an issue reported directly to me.
Type of change
Please delete options that are not relevant.