Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop reading order-related information in resources to fix wrong imports #754

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

amstuta
Copy link
Collaborator

@amstuta amstuta commented Oct 17, 2024

Description

  • Don't read order-related information (ovh_subsidiary, plan, plan_option fields) in Read functions of resources that are created using an order. It makes it easier to import these resources (the order fields are no more required), and it avoid unwanted resources re-creation after an import.
  • Fix ovh_ip_service resource import and change resource's ID to be the service_name instead of order_id.
  • Fix regex that matches the /confirmTermination email so that it works in the US.
  • Update dependencies

Fixes #753
Fixes #741
Fixes #734

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • All order-related tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

mxpetit
mxpetit previously approved these changes Oct 17, 2024
@amstuta amstuta merged commit 03896c1 into master Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants