Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add retention_type to datasource ovh_dbaas_logs_cluster_retention #806

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

amstuta
Copy link
Collaborator

@amstuta amstuta commented Jan 21, 2025

Description

A new field has been added on API side: retentionType. This PR adds it in datasource ovh_dbaas_logs_cluster_retention to be able to filter retentions on the right type.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Test A: make testacc TESTARGS="-run TestAccDataSourceDbaasLogsClusterRetention"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

deathiop
deathiop previously approved these changes Jan 21, 2025
@amstuta amstuta force-pushed the dev/aamstutz/update-ldp-retention branch from 00941bc to 4220436 Compare January 21, 2025 10:00
@amstuta amstuta merged commit 98b4ae1 into master Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants