-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev/aamstutz/add instances #809
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
deathiop
requested changes
Jan 23, 2025
7004b71
to
b25e740
Compare
deathiop
reviewed
Jan 23, 2025
deathiop
reviewed
Jan 23, 2025
rbeuque74
requested changes
Jan 23, 2025
b25e740
to
87dc43a
Compare
rbeuque74
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a check of flavor availability in the tests to make sure they are not failing if the stock of this flavor is zero
87dc43a
to
84064b2
Compare
deathiop
reviewed
Jan 24, 2025
deathiop
reviewed
Jan 24, 2025
deathiop
reviewed
Jan 24, 2025
deathiop
reviewed
Jan 24, 2025
deathiop
reviewed
Jan 24, 2025
deathiop
reviewed
Jan 24, 2025
deathiop
reviewed
Jan 24, 2025
84064b2
to
657a2f0
Compare
deathiop
approved these changes
Jan 24, 2025
10 tasks
rbeuque74
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add resource and datasource for instance(s)
Type of change
How Has This Been Tested?
make testacc TESTARGS="-run TestAccCloudProjectInstance_basic"
make testacc TESTARGS="-run TestAccDataSourceCloudProjectInstances_basic"
make testacc TESTARGS="-run TestAccDataSourceCloudProjectInstance_basic"
Checklist:
go mod vendor
if I added or modifygo.mod
file