Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/aamstutz/add instances #809

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Dev/aamstutz/add instances #809

merged 3 commits into from
Jan 24, 2025

Conversation

amstuta
Copy link
Collaborator

@amstuta amstuta commented Jan 23, 2025

Description

Add resource and datasource for instance(s)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test A: make testacc TESTARGS="-run TestAccCloudProjectInstance_basic"
  • Test B: make testacc TESTARGS="-run TestAccDataSourceCloudProjectInstances_basic"
  • Test C: make testacc TESTARGS="-run TestAccDataSourceCloudProjectInstance_basic"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@amstuta amstuta requested a review from a team as a code owner January 23, 2025 14:38
@amstuta amstuta force-pushed the dev/aamstutz/add-instances branch from 7004b71 to b25e740 Compare January 23, 2025 15:48
@amstuta amstuta force-pushed the dev/aamstutz/add-instances branch from b25e740 to 87dc43a Compare January 24, 2025 08:49
Copy link
Member

@rbeuque74 rbeuque74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check of flavor availability in the tests to make sure they are not failing if the stock of this flavor is zero

@amstuta amstuta force-pushed the dev/aamstutz/add-instances branch from 87dc43a to 84064b2 Compare January 24, 2025 09:35
@amstuta amstuta force-pushed the dev/aamstutz/add-instances branch from 84064b2 to 657a2f0 Compare January 24, 2025 10:01
@amstuta amstuta mentioned this pull request Jan 24, 2025
10 tasks
@rbeuque74 rbeuque74 merged commit 4312d3d into master Jan 24, 2025
@rbeuque74 rbeuque74 deleted the dev/aamstutz/add-instances branch January 24, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants