feat(container-registry): add OVHcloud IAM feature for Managed Registry #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thcdrt
reviewed
Mar 14, 2025
|
|
||
| # ovh_cloud_project_containerregistry_iam (Data Source) | ||
|
|
||
| Use this data source to get a OVHcloud Managed Private Registry through OVHcloud IAM. |
| if err != nil { | ||
| return fmt.Errorf("calling get %s %w", endpoint, err) | ||
| } | ||
| for k, v := range res.ToMap() { |
There was a problem hiding this comment.
Suggested change
| for k, v := range res.ToMap() { | |
| for k, v := range res.ToMap() { |
| Optional: true, | ||
| ForceNew: true, | ||
| }, | ||
| "iam_enable": { |
There was a problem hiding this comment.
Suggested change
| "iam_enable": { | |
| "iam_enabled": { |
?
| return fmt.Errorf("calling get %s %w", endpoint, err) | ||
| } | ||
| for k, v := range res.ToMap() { | ||
| if k == "iam_enable" { |
There was a problem hiding this comment.
Suggested change
| if k == "iam_enable" { | |
| if k == "iam_enabled" { |
?
| if err != nil { | ||
| return fmt.Errorf("calling get %s %w", endpoint, err) | ||
| } | ||
| for k, v := range res.ToMap() { |
There was a problem hiding this comment.
Suggested change
| for k, v := range res.ToMap() { | |
| for k, v := range res.ToMap() { |
| if len(splitId) != 2 { | ||
| return nil, fmt.Errorf("import Id is not service_name/registryId formatted") | ||
| } | ||
| serviceName := splitId[0] |
There was a problem hiding this comment.
Suggested change
| serviceName := splitId[0] | |
| serviceName := splitId[0] |
| } | ||
| serviceName := splitId[0] | ||
| registryID := splitId[1] | ||
| d.SetId(serviceName + "/" + registryID) |
There was a problem hiding this comment.
Suggested change
| d.SetId(serviceName + "/" + registryID) | |
| d.SetId(serviceName + "/" + registryID) |
|
|
||
| d.SetId(serviceName + "/" + registryID) | ||
|
|
||
| log.Printf("[DEBUG] Read registry %+v", res) |
There was a problem hiding this comment.
Suggested change
| log.Printf("[DEBUG] Read registry %+v", res) | |
| log.Printf("[DEBUG] Read registry %+v", res) | |
…ry product Terraform is able to enable/disable OVHcloud IAM feature for Managed Registry product
air1bzz
force-pushed
the
feat/emo/add_container_registry_iam_feature
branch
from
8d48a11 to
edfbe4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add resource cloud_project_containerregistry_iam
This make iam actions on Managed Registry available through Terraform.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test A: make testacc TESTARGS="-run TestAccCloudProjectContainerRegistryIAMDataSource_basic"
Test Configuration:
Terraform version: terraform version: Terraform vx.y.z
Existing HCL configuration you used:
Checklist:
My code follows the style guidelines of this project
Comments
As those routes are not yet available publicly, can you contact PU.PLATFORM | Managed Kubernetes/Registry/Rancher before merging. @erwan morvan