fix the bug of uploading files in the debug info disabled environment. #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tao-xinxiu
changed the title
amouhoub
approved these changes
Apr 7, 2022
medou-boushab
pushed a commit
to medou-boushab/automation-dashboard
that referenced
this pull request
Jun 6, 2023
medou-boushab
pushed a commit
to medou-boushab/automation-dashboard
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file uploading feature is recently broken because now the debug info is disabled (https://github.com/ow2-proactive/automation-dashboard/blob/master/app/templates_versions/common/app.js#L44), so the input #selected-upload-file can no longer access the scope with the current way.
ref: angular/angular.js#9515
This PR aims to fix this problem by creating a custom directive
input-file-changeto pass the scope without debug info.