Skip to content

Remove port from IPV4 address when running under IIS #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

culyerr
Copy link

@culyerr culyerr commented Sep 30, 2016

Relates to #1109 - IPV4+Port evaluated as malformed IPv6 address.
Rework of previous PR - code moved into IIS Module.

@zimmerle
Copy link
Contributor

zimmerle commented Oct 3, 2016

Hi @culyerr,

Thank you for the patch! Just to confirm, the only piece to be merged is the commit: 20dec1c, is that right?

@zimmerle zimmerle self-assigned this Oct 3, 2016
@culyerr
Copy link
Author

culyerr commented Oct 3, 2016

Hi Felipe,

Yes that is correct.

Cheers,

Robert

On Mon, Oct 3, 2016 at 2:43 PM, Felipe Zimmerle [email protected]
wrote:

Hi @culyerr https://github.com/culyerr,

Thank you for the patch! Just to confirm, the only piece to be merged is
the commit: 20dec1c
20dec1c,
is that right?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1220 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKTqSyiIrNZgfkukytmx6L5h-TFydlW_ks5qwQZ3gaJpZM4KK-HV
.

Robert Culyer
Actus Mobile
Sentinel House, Harvest Crescent, Fleet, Hampshire, GU51 2UZ, UK
44 (0) 7834 192906

zimmerle added a commit that referenced this pull request Oct 5, 2016
@zimmerle
Copy link
Contributor

zimmerle commented Oct 5, 2016

Thank you @culyerr. Your patch was merged.

@itrade-it
Copy link

Hi @zimmerle,

can you explain how can I edit my IIS modsecurity release-2.9.1 installation with this patch?
Or can you give me some idea about IIS modsecurity release-2.9.2 will be available?
Thank you all very much for your effort.
Regards.

Francesco

@davidjrh
Copy link

davidjrh commented Jun 13, 2017

Yeah, just having the same issue. Seems we will need to build our own patched version until the 2.9.2 release

EDIT: after spending several hours following the howtos, trying to have the same setup, etc. I surrender...I will give another try tomorrow :(

EDIT 2:
Ok, with the help of @cesarab we got the build working using the VS 2017 runtime. The fix seems to work.

@zimmerle
Copy link
Contributor

2.9.2 is out there :) it already includes this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants