Skip to content

Option to disable logging of log producer in audit log #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Option to disable logging of log producer in audit log #1382

wants to merge 2 commits into from

Conversation

marcstern
Copy link

when log level < 9.
[Issue #1069 - Marc Stern]

@zimmerle zimmerle self-assigned this Apr 10, 2017
@zimmerle
Copy link
Contributor

Please make sure that the JSON audit log is also covered.

@marcstern
Copy link
Author

done

@@ -1174,6 +1174,9 @@ void sec_audit_logger_json(modsec_rec *msr) {
yajl_kv_bool(g, "response_body_dechunked", 1);
}

#ifdef LOG_NO_PRODUCER
if (msr->txcfg->debuglog_level < 9) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this condition here. It does not seems to be doing what you aiming to do in the patch/commit description.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, seems to be part of another patch.
Do I recommit? It seems I cannot amend (actually, I can but it detects no difference if I try)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please. Try to amend all the commits and make this patch a single shot. addressing those comments.

@zimmerle
Copy link
Contributor

Hi @marcstern,

Made a comment in your patch, please verify. Before send me any updates make sure to do it in a clean tree. Please also avoid to long commit to replaced the \r with \r\n. Thanks.

@zimmerle zimmerle closed this Apr 26, 2017
@marcstern
Copy link
Author

I can't see, in "Files changed", in which files \r were replaced by \r\n.
I can't find this on my local copy either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants