Option to disable logging of stopwatches in audit log. #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2017 14:46
[Issue #1067 - Marc Stern]
|
Please make sure that the JSON audit log is also covered. |
|
done |
zimmerle
reviewed
Apr 26, 2017
CHANGES
Outdated
| @@ -1,7 +1,7 @@ | |||
| DD MMM YYYY - 2.9.2 - To be released | |||
| ------------------------------------ | |||
|
|
|||
| * {dis|en}able-filename-logging: Option to disable logging of stopwatches | |||
There was a problem hiding this comment.
Same as others: make sure to not perform a fix on the top of your own fix. Try to keep this feature a one-patch thing.
zimmerle
reviewed
Apr 26, 2017
| @@ -1,2285 +1,2288 @@ | |||
| /* | |||
There was a problem hiding this comment.
This seems the \r\n problem.
I explicitely replaced all \r\n by \r but git can't see any diff to commit.
What should I do?
|
Closing as explained in the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Issue #1067 - Marc Stern]