Multipart names may include single quote if double-quote enclosed #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @martinhsv , this fix will be on which release? Thanks |
|
It will be included automatically in the next official release in each of v2.9.x and v3.0.x. But it is available immediately for anyone who clones from github and builds ModSecurity themselves. |
|
Hi @martinhsv , can you double check also with this rule SecRule FILES_NAMES|FILES: https://github.com/coreruleset/coreruleset/blob/v3.0.2/rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf#L100 (pls change the branch)? Will the name="ab'cd" passes this rule? |
|
Hello @binhjy , The coreruleset is managed by a separate group. If you have questions about the specific behaviour of individual rules, you should contact them directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reduces the set of use cases that result in 'Invalid Quoting' being flagged during multipart parsing of the Content-Disposition's 'name' or 'filename'.
The following will no longer result in 'Invalid Quoting':
The following will continue to result in 'Invalid Quoting':
This change matches recent updates done in v2, see that pull request for more detail:
#2660