Fix build issue with Lua >= 5.3 #837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zimmerle Yes, the change does not affect older Lua versions, I tested the patch with Lua 5.2.2 (default in Fedora 21) and Lua 5.3.0 (default in Fedora Rawhide / devel). EDIT: build logs on fedora buildsystem: https://kojipkgs.fedoraproject.org//packages/mod_security/2.9.0/1.fc23/data/logs/x86_64/build.log |
zimmerle
pushed a commit
that referenced
this pull request
Apr 6, 2015
|
The build seems fine, however there are some crashes on runtime. I am investigating. We have two new build slaves for Lua 5.2 and 5.3: |
|
Hi @athmane, Thanks for the patch. Partially merged and fixed into our mainline. It will be released as part of ModSecurity v2.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please find this PR to build mod_security with Lua 5.3 (the default in Fedora rawhide).