Allow user to choose between TLS versions(TLSProtocol option introduced)... #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimmerle
pushed a commit
that referenced
this pull request
Jan 6, 2016
|
Hi @badbug0101, Thank you for the patch! Sorry for the long time to review it. It is now on our Buildbots. |
|
Hi @badbug0101, Your code was merged and it will be released as part of ModSecurity version 2.9.1 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new option
TLSProtocolallows use to select the TLS protocol version to use:TLSProtocol 2If the detected libcurl version at runtime is less than 7.34.0, then it reverts back to the old method (i.e., use TLS v1.x) since version below 7.34.0 do not support TLS v1.2.