Merge pull request #40 from owncloud/code-style-improvements

Code style improvements

Author: PrajwolAmatya

src/App.vue

@@ -123,7 +123,7 @@ if (navigator.hardwareConcurrency) {
   maxWebWorkers = Math.min(navigator.hardwareConcurrency, 7)
 }
 
-var config = {
+const config = {
   maxWebWorkers,
   startWebWorkersOnDemand: true,
   taskConfiguration: {
@@ -281,7 +281,7 @@ export default defineComponent({
         console.error('Error initalizing cornerstone core', e)
       }
     },
-    addWadouriPrefix(url: string) {
+    addWadouriPrefix(url: string): string {
       return 'wadouri:' + url
     },
     async fetchVipMetadataInformation(imageId) {
@@ -419,7 +419,7 @@ export default defineComponent({
         } else {
           // image information from viewport have already been added
           // storing elements in temp variable
-          var tempImageInformation = this.imageInformation
+          const tempImageInformation = this.imageInformation
           // adding image information elements from viewport (tempImageInformation) in proper order
           this.imageInformation = tempImageInformation
             .slice(0, 1)
@@ -626,7 +626,6 @@ export default defineComponent({
     },
     setRotation(newRotation) {
       this.currentImageRotation = newRotation
-      const { rotation } = this.viewport.getProperties()
       this.viewport.setProperties({ rotation: this.currentImageRotation })
       this.viewport.render()
     },

src/components/MetadataSidebarTableRow.vue

@@ -1,6 +1,6 @@
 <template>
   <tr class="dicom-metadata-section">
-    <th colspan="2">
+    <th colspan="2" scope="colgroup">
       <p
         class="oc-py-s oc-font-semibold dicom-metadata-section-title"
         :class="isFirstSection ? 'dicom-metadata-first-section' : ''"

src/helper/defaultPlugins.ts

@@ -1,4 +1,3 @@
-//import DesignSystem from 'design-system'
 import { createGettext } from 'vue3-gettext'
 import { h } from 'vue'
 import { abilitiesPlugin } from '@casl/vue'
@@ -51,14 +50,6 @@ export const defaultPlugins = ({
     }
   })
 
-  /*
-  TODO: check if this is needed, if so, try to fix import
-
-  if (designSystem) {
-    plugins.push(DesignSystem)
-  }
-  */
-
   if (gettext) {
     plugins.push(createGettext({ translations: {}, silent: true }))
   } else {

src/helper/extractMetadata.ts

@@ -20,28 +20,28 @@ export const findDicomTagByValue = (value: string): string | undefined => {
 }
 
 export const formatDateTagChecker = (tag: string): boolean => {
-  return tag.endsWith('_formatDate') ? true : false
+  return tag.endsWith('_formatDate')
 }
 
 export const formatTimeTagChecker = (tag: string): boolean => {
-  return tag.endsWith('_formatTime') ? true : false
+  return tag.endsWith('_formatTime')
 }
 
 export const addSopTagChecker = (tag: string): boolean => {
-  return tag.endsWith('_addSOPuids') ? true : false
+  return tag.endsWith('_addSOPuids')
 }
 
 export const extractDicomMetadata = async (imageData: object, tags: string[], language = 'en') => {
   const extractedData: { label: string; value: string }[] = []
 
   // extracting data
-  for (let i = 0; i < tags.length; ++i) {
+  for (const tag of tags) {
     // check if tag contains an extension for date or time or SOP formatting
-    const isDate = formatDateTagChecker(tags[i])
-    const isTime = formatTimeTagChecker(tags[i])
-    const isSOP = addSopTagChecker(tags[i])
+    const isDate = formatDateTagChecker(tag)
+    const isTime = formatTimeTagChecker(tag)
+    const isSOP = addSopTagChecker(tag)
 
-    let metadataLabel = tags[i]
+    let metadataLabel = tag
     if (isDate || isTime || isSOP) {
       metadataLabel = metadataLabel.slice(0, -11) // cutting off the add-on (_formatDate or _formatTime or _addSOPuids) from the label
     }