Skip to content

Code style improvements #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 4, 2024
Merged

Code style improvements #40

merged 7 commits into from
Apr 4, 2024

Conversation

koebel
Copy link
Collaborator

@koebel koebel commented Apr 3, 2024 •
edited
Loading

Description

solving some issues detected by sonar cloud

Related Issue

Motivation and Context

improved code quality leads to better maintainability

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@koebel koebel self-assigned this Apr 3, 2024
PrajwolAmatya
PrajwolAmatya reviewed Apr 4, 2024
View reviewed changes
PrajwolAmatya
PrajwolAmatya reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM 👍

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@PrajwolAmatya PrajwolAmatya merged commit 7d6f61b into main Apr 4, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the code-style-improvements branch April 4, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya approved these changes

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@koebel koebel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koebel @PrajwolAmatya