-
Notifications
You must be signed in to change notification settings - Fork 1
adding dicom-viewer.yml #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koebel
added a commit
that referenced
this pull request
Nov 21, 2024
file still needs to be correctly configured and corresponding branch (#67) needs to be merged
saw-jan
reviewed
Nov 22, 2024
saw-jan
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
koebel
commented
Nov 25, 2024
S-Panta
reviewed
Nov 26, 2024
koebel
commented
Dec 5, 2024
S-Panta
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saw-jan
requested changes
Dec 5, 2024
|
saw-jan
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enables admins to add DICOM Viewer with only a few lines in .env to the oCIS deployment example
Related Issue
Motivation and Context
make it as easy as possible for admins to add the extension to their installation
Screenshots (if appropriate):
Types of changes
Checklist: