Skip to content

added docker file for creating docker image #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Nov 26, 2024

Description

This PR add dockerfile that can be used to create docker image.

Vite config for build is updated so that the build version inside dist that is created will have same path as defined in manifest.json inside public folder which will be copied inside the dist and later used to create docker image.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@S-Panta S-Panta changed the title added docker file and make for creating docker image added docker file and makefile for creating docker image Nov 26, 2024
@S-Panta S-Panta marked this pull request as draft November 26, 2024 12:08
@S-Panta S-Panta marked this pull request as ready for review November 26, 2024 12:11
@S-Panta S-Panta changed the title added docker file and makefile for creating docker image added docker file for creating docker image Nov 27, 2024
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@S-Panta S-Panta self-assigned this Nov 27, 2024
@S-Panta S-Panta requested a review from saw-jan November 27, 2024 06:33
@saw-jan
Copy link
Member

saw-jan commented Nov 28, 2024

we can merge this

@saw-jan saw-jan merged commit 31ec3e8 into main Nov 28, 2024
2 checks passed
@saw-jan saw-jan deleted the add-docker-file branch November 28, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants