Skip to content

test: fix broken windows tests #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025
Merged

test: fix broken windows tests #381

merged 1 commit into from
Apr 22, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Feb 14, 2025

No description provided.

@Boshen Boshen force-pushed the test branch 2 times, most recently from 56c69f6 to d99ed9b Compare February 14, 2025 14:02
@Boshen Boshen changed the title test: fix broken tests test: fix broken windows tests Feb 14, 2025
@Boshen
Copy link
Member Author

Boshen commented Feb 14, 2025

latest versions of pnpm shortened long file names on windows 🤔

@Boshen Boshen marked this pull request as draft February 14, 2025 14:07
@sapphi-red
Copy link
Member

Maybe setting this option works?
https://pnpm.io/settings#virtualstoredirmaxlength

@Boshen
Copy link
Member Author

Boshen commented Apr 22, 2025

Setting virtualStoreDirMaxLength may break contributors who are using windows (?)

Ended up changing the directory name conditionally :-(

@Boshen Boshen marked this pull request as ready for review April 22, 2025 04:53
@JounQin
Copy link
Contributor

JounQin commented Apr 22, 2025

Great job! 👍

@sapphi-red
Copy link
Member

But the one of the point of that test is to have a path longer than 260 characters. (#295 (comment)) Maybe it's fine to add a comment to the try_strip_windows_prefix instead though.

@Boshen Boshen force-pushed the test branch 3 times, most recently from c11e782 to a197e0f Compare April 22, 2025 06:35
@Boshen Boshen merged commit 3d5a4ef into main Apr 22, 2025
10 checks passed
@Boshen Boshen deleted the test branch April 22, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants