Inline identicon #2145
Merged
Inline identicon #2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Great, that seems neater too. |
iliana
approved these changes
Apr 12, 2024
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 14, 2024
oxidecomputer/console@7e34c11...2ba444c * [2ba444ca](oxidecomputer/console@2ba444ca) smarter warning suppression for unhandled routes in msw * [0de42104](oxidecomputer/console@0de42104) oxidecomputer/console#2146 * [5cae2111](oxidecomputer/console@5cae2111) turn off links test for now. it freaks me out * [37470900](oxidecomputer/console@37470900) bump most deps * [ff67b406](oxidecomputer/console@ff67b406) oxidecomputer/console#2145 * [f1e8f2ee](oxidecomputer/console@f1e8f2ee) oxidecomputer/console#2139 * [31508df8](oxidecomputer/console@31508df8) bring instance networking floating ip detach modal copy in line with floating IPs page * [a433d71a](oxidecomputer/console@a433d71a) oxidecomputer/console#2130 * [83ace42b](oxidecomputer/console@83ace42b) oxidecomputer/console#2141 * [9270a930](oxidecomputer/console@9270a930) oxidecomputer/console#2134 * [00a03637](oxidecomputer/console@00a03637) update api-diff for better way of calling oxide.ts
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 14, 2024
oxidecomputer/console@7e34c11...2ba444c * [2ba444ca](oxidecomputer/console@2ba444ca) smarter warning suppression for unhandled routes in msw * [0de42104](oxidecomputer/console@0de42104) oxidecomputer/console#2146 * [5cae2111](oxidecomputer/console@5cae2111) turn off links test for now. it freaks me out * [37470900](oxidecomputer/console@37470900) bump most deps * [ff67b406](oxidecomputer/console@ff67b406) oxidecomputer/console#2145 * [f1e8f2ee](oxidecomputer/console@f1e8f2ee) oxidecomputer/console#2139 * [31508df8](oxidecomputer/console@31508df8) bring instance networking floating ip detach modal copy in line with floating IPs page * [a433d71a](oxidecomputer/console@a433d71a) oxidecomputer/console#2130 * [83ace42b](oxidecomputer/console@83ace42b) oxidecomputer/console#2141 * [9270a930](oxidecomputer/console@9270a930) oxidecomputer/console#2134 * [00a03637](oxidecomputer/console@00a03637) update api-diff for better way of calling oxide.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console is the only app using @oxide/identicon. @iliana made a PR over there, but there's no point figuring out how to push that to npm. This PR copies that in here and changes it to render svg directly instead of producing a string that we dangerouslySetHtml with.
Confirmed the resulting SVG is the same as before: