Don't go to definition of builtin modules #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If going to builtin definitions would be desirable for some people then it could be made configurable, but I'm not sure if that's necessary. |
gatesn
suggested changes
Oct 31, 2019
test/plugins/test_definitions.py
Outdated
| @@ -40,7 +40,7 @@ def test_builtin_definition(config): | |||
|
|
|||
| # No go-to def for builtins | |||
| doc = Document(DOC_URI, DOC) | |||
| assert len(pyls_definitions(config, doc, cursor_pos)) == 1 | |||
| assert [] == pyls_definitions(config, doc, cursor_pos) | |||
There was a problem hiding this comment.
Should be assert not pyls_definitions(config, doc, cursor_pos)
pyls/plugins/definition.py
Outdated
| @@ -21,5 +21,6 @@ def pyls_definitions(config, document, position): | |||
| } | |||
| } | |||
| for d in definitions | |||
| if d.is_definition() and d.line is not None and d.column is not None and d.module_path is not None | |||
| if d.is_definition() and d.line is not None and d.column is not None and | |||
There was a problem hiding this comment.
Can you pull this out into a function? It doesn't read very clearly anymore
gatesn
reviewed
Oct 31, 2019
pyls/plugins/definition.py
Outdated
| ] | ||
|
|
||
|
|
||
| def not_internal_definition(definition): |
gatesn
approved these changes
Nov 1, 2019
This was referenced Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do Go To Definition (F12 in vscode) on a string, it opens the builtins.pyi file for python 3, because the definition is not being filtered properly.
This PR corrects that behaviour so that neither python 2 nor 3 will go to the builtins file.
This doesn't affect the behaviour with imported builtins - they still respect the configuration.