GH1184 Clean up new warnings with new version of pyright (1.1.399) #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2025
Dr-Irv
reviewed
Apr 14, 2025
| @@ -219,6 +219,7 @@ reportUnknownParameterType = false | |||
| reportUnknownVariableType = false | |||
| reportUnusedVariable = false | |||
| reportPrivateUsage = false | |||
| reportPrivateImportUsage = false | |||
There was a problem hiding this comment.
So this becomes a problem, because reportPrivateImportUsage = true is on when people use pyright and pandas-stubs is installed.
See microsoft/pyright#10248 for a discussion. It looks like the pyright maintainer is going to consider reverting the change that created this issue, so if he does that, we can handle this PR later.
There was a problem hiding this comment.
Okay that is very insightful!
Let's hold on this PR before pyright clarifies the situation, for now the other PRs I have made have locked pyright version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value