Skip to content

CI: Use bash for Windows scripts on Azure #26344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue May 11, 2019 · 6 comments · Fixed by #30431
Closed

CI: Use bash for Windows scripts on Azure #26344

jbrockmendel opened this issue May 11, 2019 · 6 comments · Fixed by #30431
Labels
Build Library building on various platforms CI Continuous Integration Clean
Milestone

Comments

@jbrockmendel
Copy link
Member

Azure now supports using bash in windows scripts, so I think we can de-duplicate some of the windows-specific shell scripts. cc @datapythonista

@gfyoung gfyoung added Build Library building on various platforms Clean labels May 12, 2019
@gfyoung
Copy link
Member

gfyoung commented May 12, 2019

Might even help with #26345

@datapythonista
Copy link
Member

Sounds great, thanks @jbrockmendel. @TomAugspurger I think you implemented the power shell scripts. Any reason we're missing not to use same scripts as in Linux/Mac?

@TomAugspurger
Copy link
Contributor

Don't think there was a reason. I just copied Numba's.

@datapythonista
Copy link
Member

I think it wasn't possible to use bash in Windows until now, so using power shell scripts made sense. My question was if you saw any reason why not to unify now that it's possible, sorry I wasn't clear. I understand you don't.

@saurav2608 do you want to give this a try? It's related to #24632

@saurav2608
Copy link

I have very less time last few months to contribute here. But I will have a look at this and if I can quickly finish off, I will work on this.

@alimcmaster1
Copy link
Member

Its great that azure now supports this - @jbrockmendel I assume you are referring to these power shell scripts implemented here: #26344 that currently live in: ci/azure directory i'm happy to take a look as migrating them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration Clean
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants