Skip to content

MAINT: PEP8 + spelling fixes in testing.py #12637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

MAINT: PEP8 + spelling fixes in testing.py #12637

wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Mar 16, 2016

No description provided.

@gfyoung gfyoung force-pushed the testing-module-maint branch from 9de2d5a to d215583 Compare March 16, 2016 04:56
@codecov-io
Copy link

Current coverage is 88.64%

Merging #12637 into master will not affect coverage as of 7f8a90b

@@            master   #12637   diff @@
=======================================
  Files          275      275       
  Stmts       133688   133688       
  Branches         0        0       
  Methods          0        0       
=======================================
+ Hit         118511   118512     +1
  Partial          0        0       
+ Missed       15177    15176     -1

Review entire Coverage Diff as of 7f8a90b

Powered by Codecov. Updated on successful CI builds.

@jreback
Copy link
Contributor

jreback commented Mar 16, 2016

theres a flake directive at the top of the file, need to remove it

@jreback jreback added the Code Style Code style, linting, code_checks label Mar 16, 2016
@jreback jreback added this to the 0.18.1 milestone Mar 16, 2016
@gfyoung gfyoung force-pushed the testing-module-maint branch from d215583 to e2496ee Compare March 17, 2016 03:33
@gfyoung
Copy link
Member Author

gfyoung commented Mar 17, 2016

Removed the directive as well as all of the flake8 violations, and Travis gives the green light. Should be good to merge.

@jreback
Copy link
Contributor

jreback commented Mar 17, 2016

thanks!

@jreback jreback closed this in e4df1ac Mar 17, 2016
@gfyoung gfyoung deleted the testing-module-maint branch March 17, 2016 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.18.1
Development

Successfully merging this pull request may close these issues.
3 participants
@gfyoung @codecov-io @jreback