TST: add tests for Timestamp.toordinal/fromordinal #13610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -235,7 +235,7 @@ class Timestamp(_Timestamp): | |||
| ---------- | |||
| ts_input : datetime-like, str, int, float | |||
| Value to be converted to Timestamp | |||
| offset : str, DateOffset | |||
| freq : str, DateOffset | |||
There was a problem hiding this comment.
let's list offset (and say it's deprecated)
There was a problem hiding this comment.
updated docstrings of class and fromordinal.
sinhrks
changed the title
Current coverage is 84.38%@@ master #13610 diff @@
==========================================
Files 142 142
Lines 51225 51225
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43225 43225
Misses 8000 8000
Partials 0 0
|
sinhrks
force-pushed
the
depr_timestamp_offset2
branch
from
6f9ac7d to
825a169
Compare
sinhrks
force-pushed
the
depr_timestamp_offset2
branch
from
825a169 to
28f8d41
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffadded tests and fixed missed doc change.